feat: hollow aggregated proofs #149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxcanfly
reviewed
Feb 13, 2025
| panic!("must provide at least 2 proofs"); | ||
| } | ||
|
|
||
| // Read all public values |
There was a problem hiding this comment.
Sorry, minor update to the inputs, we should have verification keys here as well:
There was a problem hiding this comment.
no worries! I'll wait for your PR to merge and then I can replicate it.
There was a problem hiding this comment.
should be addressed! :)
ninabarbakadze
force-pushed
the
nina/hollow-aggreagted-proofs
branch
from
e27c397 to
707643c
Compare
ninabarbakadze
commented
Feb 24, 2025
| @@ -5,10 +5,6 @@ | |||
| sp1_zkvm::entrypoint!(main); | |||
|
|
|||
| use blevm_common::BlevmOutput; | |||
| use celestia_types::nmt::Namespace; | |||
There was a problem hiding this comment.
I was seeing warnings for unused imports
rootulp
reviewed
Feb 24, 2025
There was a problem hiding this comment.
- Can you please add to PR description how this was tested? Also linking to GH issue helps reviewer.
- How does a developer switch from using the real aggregate proof to the hollowed out proof?
- [Optional but highly encouraged] the point of this issue is to make it easier / fasted to develop on this repo. We should include that in the description of Aggregated empty proofs for blEVM #144. In this PR, we could add to the README that it takes "x" minutes to generate a real aggregate proof for 2 EVM blocks. It takes "y" minutes to generate a hollowed out aggregate proof. That way developers know how long it should take to generate. See for an example
celestia-zkevm-ibc-demo/provers/blevm/README.md
Lines 91 to 96 in 231c10c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144