Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preemptive panic recovery #75

Merged
merged 2 commits into from
Apr 20, 2024
Merged

fix: preemptive panic recovery #75

merged 2 commits into from
Apr 20, 2024

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Apr 20, 2024

This protects the library from potential dos vectors introduced by go-fraud users in the proof deserialization and verification code paths.

@Wondertan Wondertan self-assigned this Apr 20, 2024
@celestia-bot celestia-bot requested review from gupadhyaya, a team, yarikbratashchuk and nashqueue and removed request for a team April 20, 2024 17:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.14%. Comparing base (642bb01) to head (3298b67).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   64.63%   65.14%   +0.51%     
==========================================
  Files           6        6              
  Lines         410      416       +6     
==========================================
+ Hits          265      271       +6     
  Misses        109      109              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

fraudserv/service.go Outdated Show resolved Hide resolved
fraudserv/service.go Outdated Show resolved Hide resolved
@Wondertan Wondertan merged commit 8b5120a into main Apr 20, 2024
9 checks passed
@Wondertan Wondertan deleted the hlib/panic-recovery branch April 20, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants