Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suntzu.json #378

Closed
wants to merge 4 commits into from
Closed

Suntzu.json #378

wants to merge 4 commits into from

Conversation

suntzu93
Copy link
Contributor

No description provided.

@github-actions
Copy link

Please format your gentx by running jq . path/to/gentx.json > path/to/gentx.json_tmp && mv path/to/gentx.json_tmp path/to/gentx.json and resubmit the PR.

@github-actions
Copy link

Please format your gentx by running jq . path/to/gentx.json > path/to/gentx.json_tmp && mv path/to/gentx.json_tmp path/to/gentx.json and resubmit the PR.

@@ -1,3 +1,4 @@
user,pr
MSevey,3
liamsi,378
celestia-bot,378
Copy link
Member

@liamsi liamsi Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSevey I think we should only add the account that created the PR. Using github.actor does not work for already open PRs/manually triggering CI/updating the branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? this wasn't happening when I was testing. It should be using the author of the PR. Will debug.

@github-actions
Copy link

Please format your gentx by running jq . path/to/gentx.json > path/to/gentx.json_tmp && mv path/to/gentx.json_tmp path/to/gentx.json and resubmit the PR.

@liamsi liamsi mentioned this pull request Oct 22, 2023
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suntzu93 we are still tweaking CI here.
Do you mind rebasing on master and pushing again.
Alternatively close this one and open a new one from the latest master branch. Thank you!

@suntzu93 suntzu93 closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants