Debit 0 value check (#10930)

celo-org · Feb 9, 2024 · 0bfa0e3 · 0bfa0e3
1 parent c7a5553
commit 0bfa0e3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/protocol/contracts-0.8/stability/FeeCurrencyAdapter.sol b/packages/protocol/contracts-0.8/stability/FeeCurrencyAdapter.sol
@@ -65,6 +65,7 @@ contract FeeCurrencyAdapter is Initializable, CalledByVm, IFeeCurrencyAdapter {
    */
   function debitGasFees(address from, uint256 value) external onlyVm {
     uint256 valueScaled = downscale(value);
+    require(valueScaled > 0, "Scaled debit value must be > 0.");
     debited = valueScaled;
     adaptedToken.debitGasFees(from, valueScaled);
   }

diff --git a/packages/protocol/test-sol/stability/FeeCurrencyAdapter.t.sol b/packages/protocol/test-sol/stability/FeeCurrencyAdapter.t.sol
@@ -180,6 +180,12 @@ contract FeeCurrencyAdapter_DebitGasFees is FeeCurrencyAdapterTest {
     feeCurrencyAdapter.debitGasFees(address(this), 1000);
   }
 
+  function test_ShouldRevert_WhenScaledDebitValueIs0() public {
+    vm.expectRevert("Scaled debit value must be > 0.");
+    vm.prank(address(0));
+    feeCurrencyAdapter.debitGasFees(address(this), 1e7);
+  }
+
   function test_ShouldDebitCorrectAmount_WhenExpectedDigitsOnlyOneBigger() public {
     debitFuzzyHelper(7, 1e1);
   }