-- TODO; compiles test when filtering

celo-org · Sep 12, 2024 · de06b4e · de06b4e
1 parent 43ae993
commit de06b4e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/packages/protocol/contracts-0.8/common/EpochManager.sol b/packages/protocol/contracts-0.8/common/EpochManager.sol
@@ -321,7 +321,6 @@ contract EpochManager is
       totalRewards += validatorReward;
     }
     // Mint all cUSD required for payment and the corresponding CELO
-    // TODO(soloseng): add test to check that epoch manager received funds.
     validators.mintStableToEpochManager(totalRewards);
     // this should have a setter for the oracle.
 

diff --git a/packages/protocol/contracts-0.8/governance/Validators.sol b/packages/protocol/contracts-0.8/governance/Validators.sol
@@ -647,7 +647,6 @@ contract Validators is
     group.slashInfo.lastSlashed = block.timestamp;
   }
 
-  // TODO(soloseng): add test to check that this function can only mint to epoch manager.
   function mintStableToEpochManager(
     uint256 amount
   ) external onlyL2 nonReentrant onlyRegisteredContract(EPOCH_MANAGER_REGISTRY_ID) {

diff --git a/packages/protocol/test-sol/devchain/migration/Migration.t.sol b/packages/protocol/test-sol/devchain/migration/Migration.t.sol
@@ -218,7 +218,6 @@ contract EpochManagerIntegrationTest is IntegrationTest, MigrationsConstants {
     epochManager.initializeSystem(100, block.number, firstElected);
   }
 
-  // XXX(soloseng): fails because EpochManager is not yet permissioned by stableToken to mint
   function test_SetsCurrentRewardBlock() public {
     _MockL2Migration(validatorsList);
 

diff --git a/packages/protocol/test-sol/unit/governance/voting/Election.t.sol b/packages/protocol/test-sol/unit/governance/voting/Election.t.sol
@@ -7,6 +7,7 @@ import { TestConstants } from "@test-sol/constants.sol";
 import { Utils } from "@test-sol/utils.sol";
 
 import "@celo-contracts/common/FixidityLib.sol";
+import "@celo-contracts/common/Registry.sol";
 import "@celo-contracts/governance/Election.sol";
 import "@celo-contracts/governance/test/MockLockedGold.sol";
 import "@celo-contracts/governance/test/MockValidators.sol";
@@ -162,6 +163,7 @@ contract ElectionTest is Utils, TestConstants {
   }
 
   function _whenL2() public {
+    blockTravel(ph.epochSize() + 1);
     uint256 l1EpochNumber = election.getEpochNumber();
 
     address[] memory _elected = new address[](2);
@@ -217,7 +219,6 @@ contract ElectionTest_SetElectabilityThreshold is ElectionTest {
   }
 }
 
-// TODO(soloseng): need to update epochNumber for L2, to make it !=0
 contract ElectionTest_SetElectabilityThreshold_L2 is ElectionTest {
   function test_shouldSetElectabilityThreshold() public {
     _whenL2();