Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@celo/abis and @celo/contracts should not be available to publish by default #10832

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

shazarre
Copy link
Contributor

@shazarre shazarre commented Dec 14, 2023

Description

This PR sets removes version and marks as private @celo/abis and @celo/contracts packages to avoid releasing valid version by mistake.

Other changes

None.

Tested

Ran RELEASE_VERSION=10.0.0-local yarn prepare_contracts_and_abis_publishing to see if it still replaces versions in package.json and it does (as well as marks the packages as public).

Ran yarn prepare_contracts_and_abis_publishing to see if it doesn't replace versions in package.json and it doesn't. It also keeps the packages private.

Ran the workflow manually and noticed that package has been released with provided tag. For automated runs after commits it didn't release anything as expected.

Backwards compatibility

It's backwards compatible.

Documentation

None.

Copy link

changeset-bot bot commented Dec 14, 2023

⚠️ No Changeset found

Latest commit: 9090105

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defensive coding

@aaronmgdr aaronmgdr self-requested a review December 14, 2023 12:16
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need something that doesnt error out but also wont accidently publish

@shazarre shazarre changed the title Explicitly invalid package version for @celo/abis and @celo/contracts by default @celo/abis and @celo/contracts should not be available to publish by default Dec 14, 2023
@aaronmgdr
Copy link
Member

i feel like i remember having an issue setting private: false, before where it would complain that it should just be removed. maybe that was just a lint and not an real isssue.

@shazarre shazarre marked this pull request as ready for review December 15, 2023 09:41
@shazarre shazarre requested a review from a team as a code owner December 15, 2023 09:41
@shazarre shazarre requested a review from a team December 15, 2023 09:41
@shazarre shazarre enabled auto-merge (squash) December 15, 2023 10:06
@shazarre shazarre merged commit 3902e9c into master Dec 15, 2023
35 of 37 checks passed
@shazarre shazarre deleted the shazarre/explictly_invalid_package_version branch December 15, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants