Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Foundry CI output tests easier to read on failure #10835

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Make Foundry CI output tests easier to read on failure #10835

merged 10 commits into from
Dec 19, 2023

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Dec 18, 2023 •
edited
Loading

Make tests with Foundry have the same structure as the ones we used to have for truffle.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 408fe27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@martinvol martinvol marked this pull request as ready for review December 18, 2023 14:06
@martinvol martinvol requested review from a team as code owners December 18, 2023 14:06
@martinvol martinvol changed the title Organize Foundry CI Make Foundry tests easier to read Dec 18, 2023
@martinvol martinvol changed the title Make Foundry tests easier to read Make Foundry CI output tests easier to read on failure Dec 18, 2023
soloseng
soloseng requested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Identity contracts test

@martinvol
Copy link
Contributor Author

@soloseng great catch!

soloseng
soloseng approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@martinvol martinvol merged commit 479640b into master Dec 19, 2023
34 of 35 checks passed
@martinvol martinvol deleted the martinvol/organizeFoundryInCi branch December 19, 2023 18:22
@martinvol martinvol mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloseng soloseng soloseng approved these changes

@pahor167 pahor167 pahor167 approved these changes

@lvpeschke lvpeschke lvpeschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinvol @lvpeschke @pahor167 @soloseng