Soloseng/validator-test-foundry-migration

[soloseng]

Other Changes

Updated the celo-foundry submodule, to point to a different commit hash, where the precompile handler uses bytes instead of bytes32 for its mock functions.

I added two new files to help with the generating ECDSA public key. These contracts are based on 0xcyphered/secp256k1-solidity, but use solidity version 0.5.13 instead.

Tested

Unit test

Related issues

• Fixes test/governance/validators/validators.ts #10867

[soloseng]

I'm a bit skeptical about the validity of the test that mock the return value of FRACTION_MUL().

Specifically the tests in ValidatorsTest_CalculateEpochScore && ValidatorsTest_CalculateGroupEpochScore since they don't actually test the FRACTION_MUL() .

Thoughts?

[pahor167]

Good job!

[openzeppelin-code]

Soloseng/validator-test-foundry-migration

Generated at commit: 4f231aac6c4708eac0802999242a7afa8b0e1b32

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 3 0 15 39 59
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector