Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow gatewayFeeRecipient to be omitted if empty #10985

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Allow gatewayFeeRecipient to be omitted if empty #10985

merged 1 commit into from
Jun 25, 2024

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Apr 30, 2024

@karlb karlb requested a review from a team as a code owner April 30, 2024 12:45
@karlb karlb requested a review from alvarof2 April 30, 2024 12:45
aaronmgdr
aaronmgdr approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird test but 🙌🏻

@karlb karlb force-pushed the karlb/optional-gatewayFeeRecipient branch 2 times, most recently from d91f408 to 306a5ab Compare June 25, 2024 08:08
@karlb karlb force-pushed the karlb/optional-gatewayFeeRecipient branch from 306a5ab to 00b3e79 Compare June 25, 2024 08:09
@karlb karlb enabled auto-merge (squash) June 25, 2024 08:21
@karlb karlb merged commit cfe8a4b into master Jun 25, 2024
28 checks passed
@karlb karlb deleted the karlb/optional-gatewayFeeRecipient branch June 25, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmgdr aaronmgdr aaronmgdr approved these changes

@alvarof2 alvarof2 Awaiting requested review from alvarof2 alvarof2 is a code owner automatically assigned from celo-org/devopsre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlb @aaronmgdr