-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Celo Dependencies #11184
base: master
Are you sure you want to change the base?
Upgrade Celo Dependencies #11184
Conversation
Upgrade Celo Dependencies
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a conflict with the web3 dependency, that is causing build to fail. Might be worth also updating web3 dep
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@celo/[email protected], npm/@celo/[email protected], npm/@celo/[email protected] |
08f6370
to
73d682e
Compare
I dont see how this could have caused anvil devchain test to break |
remove demurage / inflation test on Stable transfer e2e as that no longer exists
73d682e
to
fac3c0c
Compare
const PGPORT = process.env['PGPORT'] || '5432' | ||
const PGDATABASE = process.env['PGDATABASE'] || 'blockscout' | ||
const PROVIDER_URL = process.env['PROVIDER_URL'] || 'http://localhost:8545' | ||
const PGUSER = process.env.PGUSER || 'postgres' |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
Description
celo package upgrades have some important upgrades
also its best to upgrade web3 at same time as contractkit.
Remove test for demurage/inflation (this feature was removed from StableToken Contract)
Other changes
yarn install automatically added packageManager field.
Tested