Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Celo Dependencies #11184

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade Celo Dependencies #11184

wants to merge 2 commits into from

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Aug 14, 2024

Description

celo package upgrades have some important upgrades

also its best to upgrade web3 at same time as contractkit.

Remove test for demurage/inflation (this feature was removed from StableToken Contract)

Other changes

yarn install automatically added packageManager field.

Tested

@aaronmgdr aaronmgdr requested review from a team as code owners August 14, 2024 13:22
Copy link

Upgrade Celo Dependencies

Generated at commit: 61ac6c211265d840053e14fe7e31ad779e6a4a9a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
3
0
15
41
61
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a conflict with the web3 dependency, that is causing build to fail. Might be worth also updating web3 dep

Copy link

socket-security bot commented Aug 28, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@celo/[email protected], npm/@celo/[email protected], npm/@celo/[email protected]

View full report↗︎

@aaronmgdr
Copy link
Member Author

I dont see how this could have caused anvil devchain test to break

remove demurage / inflation test on Stable transfer e2e as that no longer exists
const PGPORT = process.env['PGPORT'] || '5432'
const PGDATABASE = process.env['PGDATABASE'] || 'blockscout'
const PROVIDER_URL = process.env['PROVIDER_URL'] || 'http://localhost:8545'
const PGUSER = process.env.PGUSER || 'postgres'

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "postgres" is used as
user name
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants