E2E EpochManager test + Epoch truffle migrations & Anvil L2 migration build fix #11198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss-unit-and-integration-test
Fails when it hits a precompile in `EpochRewards.sol`
Still missing tests
fix name conflict
…ss-unit-and-integration-test
…ss-unit-and-integration-test
Base automatically changed from
soloseng/startNextEpochProcess-unit-and-integration-test
to
feat/l2-epoch-system
September 17, 2024 00:40
martinvol
reviewed
Sep 17, 2024
| @@ -181,6 +186,7 @@ contract EpochManager is | |||
| // TODO complete this function | |||
There was a problem hiding this comment.
Are these TODO still required?
martinvol
reviewed
Sep 17, 2024
| bool processed; | ||
| uint256 epochRewards; | ||
| } | ||
|
|
||
| // TODO this should be able to get deleted easily |
There was a problem hiding this comment.
is this TODO still required?
martinvol
reviewed
Sep 17, 2024
martinvol
force-pushed
the
pahor/truffleMigrations
branch
from
4f31ffc
to
95a6b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epoch truffle migrations & Anvil L2 migration build fix