Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soloseng/dynamically-fetch-epochmanagerenabler-address #11207

Conversation

soloseng
Copy link
Contributor

@soloseng soloseng commented Sep 16, 2024

Description

  • Dynamically fetch the epochManagerEnabler address from the registry. This helps by not having to hardcode the address, as it would require some modification of our deploy scripts.

  • Dynamically fetch carbonOffsettingPartner address from epochRewards contract. This avoids having two different places where the address can be set.

updated registry.

Other changes

removed onlyL1 modifier from EpochRewards contract. This allows governance to continue optimizing rewards distribution and updating allocated fractions.

Tested

unit test implemented by #11191

Related issues

@soloseng soloseng requested a review from a team as a code owner September 16, 2024 17:53
@soloseng soloseng self-assigned this Sep 16, 2024
@martinvol
Copy link
Contributor

I think you just need to add epochManagerInitializer to the registry in the tests and that'd be ready to go

@soloseng soloseng merged commit f4b4564 into feat/l2-epoch-system Sep 17, 2024
38 checks passed
@soloseng soloseng deleted the soloseng/dynamically-fetch-epochmanagerenabler-address branch September 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants