-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soloseng/dynamically-fetch-epochmanagerenabler-address #11207
Merged
soloseng
merged 11 commits into
feat/l2-epoch-system
from
soloseng/dynamically-fetch-epochmanagerenabler-address
Sep 17, 2024
Merged
Soloseng/dynamically-fetch-epochmanagerenabler-address #11207
soloseng
merged 11 commits into
feat/l2-epoch-system
from
soloseng/dynamically-fetch-epochmanagerenabler-address
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahor167
reviewed
Sep 16, 2024
pahor167
reviewed
Sep 16, 2024
martinvol
approved these changes
Sep 17, 2024
I think you just need to add epochManagerInitializer to the registry in the tests and that'd be ready to go |
soloseng
deleted the
soloseng/dynamically-fetch-epochmanagerenabler-address
branch
September 17, 2024 21:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamically fetch the
epochManagerEnabler
address from the registry. This helps by not having to hardcode the address, as it would require some modification of our deploy scripts.Dynamically fetch
carbonOffsettingPartner
address fromepochRewards
contract. This avoids having two different places where the address can be set.updated registry.
Other changes
removed
onlyL1
modifier fromEpochRewards
contract. This allows governance to continue optimizing rewards distribution and updating allocated fractions.Tested
unit test implemented by #11191
Related issues