Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProxyFactory and ProxyFactory08 cleanup #11249

Merged
merged 6 commits into from
Oct 16, 2024
Merged

ProxyFactory and ProxyFactory08 cleanup #11249

merged 6 commits into from
Oct 16, 2024

Conversation

m-chrzan
Copy link
Contributor

Description

Cleans up the ProxyFactory contracts.

  • Added NatSpecs
  • In both contracts, there was an unnecessary internal function that could be inlined.

Related issues

@m-chrzan m-chrzan requested a review from a team as a code owner October 16, 2024 10:42
@m-chrzan m-chrzan enabled auto-merge (squash) October 16, 2024 21:25
@m-chrzan m-chrzan merged commit ad543ec into release/core-contracts/12 Oct 16, 2024
24 of 25 checks passed
@m-chrzan m-chrzan deleted the m-chrzan/proxy-factory-cleanup branch October 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloseng soloseng soloseng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-chrzan @soloseng