-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Alpha Vantage apdater + and support for API keys #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just some nits
baseVolume: new BigNumber(1), | ||
quoteVolume: new BigNumber(1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How difficult would it be to have volume be optional here, and then assigning "fake" volume, somewhere else in the chain in a way that it won't get fucked if we mix "fake volume" exchange with "real volume" exchanges.
Alternatively, could we add another field here, which is something like "volumeMissing: true" and set it to false in the priceObjectMetadata
in Base
, and then when aggregating throw an error unless either all of them are volumeMissing: true or false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this and left a comment here outlining the approach I took
705c0b1
to
bc4762d
Compare
Updated with a bunch of changes since the last review, the most important one being 628ca4e to add an The idea is that we would set it for configurations that involve an FX rate along the way, for example, CELOXOF:
while configurations that are only composed of FX rates (for example, EURXOF) don't need to set anything, as the default volume of The risk is that we could miss setting the property in a place where is actually necessary and end up "under-weighting" a price source, but imho this can just be part of the price source review process, similarly to how we need to ensure that the |
Description
This adds a first FX provider adapter (Alpha Vantage) which we will use for deploying the first XOF oracles on testnets. In addition to the adapter the client is also extended to support a new
API_KEYS
env variable in the format<exchange-identifier-1>:<api-key-1>,<exchange-identifier-2>:<api-key-2>
, which is parsed and passed onto their respective adapters.Other FX adapters will follow later on once we have more clarity on the final set of price sources.
Other changes
Tested
Related issues