fix: add transferOwnership() to proxy abi list #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7c9eb4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shazarre
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #467 +/- ##
=======================================
Coverage 70.03% 70.03%
=======================================
Files 292 292
Lines 11277 11278 +1
Branches 1675 1689 +14
=======================================
+ Hits 7898 7899 +1
- Misses 3230 3250 +20
+ Partials 149 129 -20
|
nicolasbrugneaux
approved these changes
Nov 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(copied from #466)
Description
This adds the abi definition for
_transferOwnership(address)next to the other common proxy functions underPROXY_ABI, as we ran into an issue decoding a call on a proxy contract as part of CGP156Other changes
N/A
Tested
Tested that the
_transferOwnership()calls under CGP156 json can be decodedPR-Codex overview
This PR focuses on adding the
transferOwnership()function to the proxy ABI list in thecontractkitpackage and updating the documentation accordingly.Detailed summary
TRANSFER_OWNERSHIP_ABItopackages/sdk/contractkit/src/proxy.ts.PROXY_ABIto includeTRANSFER_OWNERSHIP_ABI.TRANSFER_OWNERSHIP_ABIindocs/sdk/contractkit/modules/index.mdanddocs/sdk/contractkit/modules/proxy.md.