Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cel2 Version of Docs #1500

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

New Cel2 Version of Docs #1500

wants to merge 17 commits into from

Conversation

sodofi
Copy link
Contributor

@sodofi sodofi commented Sep 26, 2024

No description provided.

@sodofi sodofi requested review from a team as code owners September 26, 2024 22:35
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for celo-docs ready!

Name Link
🔨 Latest commit 0e570ca
🔍 Latest deploy log https://app.netlify.com/sites/celo-docs/deploys/670ec8eba92018000838679e
😎 Deploy Preview https://deploy-preview-1500--celo-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 75 (no change from production)
SEO: 81 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sodofi sodofi requested review from marekolszewski, lvpeschke and katen0ra and removed request for alvarof2 September 27, 2024 19:42
@sodofi sodofi changed the title updated dev resources branch with main updates to merge with main New Cel2 Version of Docs Sep 27, 2024
docs/developer/explorers/block-explorers.md Outdated Show resolved Hide resolved
@lvpeschke
Copy link
Contributor

Note: I did not review every page, relying on the other reviewers to have a look here.

@@ -0,0 +1,20 @@
---
title: Verify with Celo Explorer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be replace with blockscout verifiucation page.


Celo wallets should follow [BIP44](https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki) for deriving private keys from [BIP39 mnemonics](https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki). Celo's key derivation path is `m/44'/52752'/0'/0`. The first key is typically the `account key` for balance transfers, while the second key can be derived as the `dataEncryptionKey` for encrypting information.

### Identity Protocol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call this Social Connect


### Wallet Address Management

When transferring assets, wallets should check the receiving account's `walletAddress`. Smart contract accounts may have different recovery characteristics but receive funds at a different address. A `walletAddress` of `0x0` indicates that a different mechanism is required to acquire the `walletAddress`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this is really true

Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

45 pages and not even a description. can we do better?

@aaronmgdr
Copy link
Member

remember that sweet bridging page @therealharpaljadeja made for the dango launch? lets bring that back


### Key Derivation

Celo wallets should follow [BIP44](https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki) for deriving private keys from [BIP39 mnemonics](https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki). Celo's key derivation path is `m/44'/52752'/0'/0`. The first key is typically the `account key` for balance transfers, while the second key can be derived as the `dataEncryptionKey` for encrypting information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self about derivation key standard. re defaulting to ethereum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants