Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan CIP-64 to CIP-66 switch #112

Open
3 tasks
Tracked by #64
karlb opened this issue Apr 23, 2024 · 5 comments
Open
3 tasks
Tracked by #64

Plan CIP-64 to CIP-66 switch #112

karlb opened this issue Apr 23, 2024 · 5 comments
Labels
type:question Further information is requested

Comments

@karlb
Copy link

karlb commented Apr 23, 2024

  • At which time will CIP-66 support be included in the blockchain?
  • When will client libraries start using CIP-66? How do they know when it is supported by the blockchain client?
  • We will have to whitelist both the FeeCurrencyAdapter deployments (to support CIP-64) and the real token (for CIP-66). Do we want to take additional measure to avoid accidentally using the wrong one when both are whitelisted?
@aaronmgdr
Copy link
Member

ah i have been assuming that 66 will be supported from day 1 on cel2. if not we need to re do how we are implementing rpc caller libraries

@karlb
Copy link
Author

karlb commented Jun 11, 2024

The basic plan is:

  • Add support for CIP-66 without changing the FeeCurrencyDirectory . Both CIP-64 and CIP-66 txs will use the adapters. Libraries can start enabling CIP-66 txs now.
  • Remove support for CIP-64. Now everyone will use CIP-66 txs with the adapters.
  • Add non-adapted tokens to the FeeCurrencyDirectory. The real tokens can be safely used because CIP-64 is not supported anymore. Listing all entries might be a bit confusing at this stage, since two entries for the same token are present in some cases (the adapter and the token itself).
  • Remove adapters from FeeCurrencyDirectory .

@karlb
Copy link
Author

karlb commented Jul 23, 2024

When will client libraries start using CIP-66? How do they know when it is supported by the blockchain client?

Suggestion: client libraries will default to CIP-64 for now and provide a way to explicitly request CIP-66 txs. Once CIP-66 is available on all Celo networks, new releases of client libraries will default to using CIP-66.

Does that sound good @aaronmgdr?

@aaronmgdr
Copy link
Member

to be honest because of the new field im not sure if we will be able to get all libraries to default to 66. specifically viem. because while they do have a custom fees modules, it only is for calculating maxFeePerGas maxPriorityFeePerGas. they would need the function to be allowed to return arbitrary fields / data which they might do but you know...

@karlb
Copy link
Author

karlb commented Jul 24, 2024

That's a good point. Then let's only settle on the "client libraries will default to CIP-64 for now and provide a way to explicitly request CIP-66 txs." part now and investigate the other questions later as part of this issue.

@ezdac ezdac added the type:question Further information is requested label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants