Port the block limit per fee currency #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezdac
force-pushed
the
ezdac/issue-65
branch
6 times, most recently
from
80c41f9
to
7107f13
Compare
ezdac
commented
May 7, 2024
carterqw2
reviewed
May 13, 2024
carterqw2
reviewed
May 13, 2024
ezdac
force-pushed
the
ezdac/issue-65
branch
2 times, most recently
from
705ee56
to
1f2b47f
Compare
palango
reviewed
May 16, 2024
Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). However there is a small difference: The `MultiGasPool` does not consider the currency whitelist here because fee-currency validity will be checked by the transaction-validation logic upon adding transactions to the tx-pool. This means that the `GetPool` method will create a GasPool on the fly, if it is not memoized in the internal map yet, no matter if the feeCurrency is whitelisted or not. In practice, this will never happen for non-whitelisted currencies, because those transactions will not make it to the tx-pool.
carterqw2
reviewed
Jun 3, 2024
carterqw2
approved these changes
Jun 3, 2024
carterqw2
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
karlb
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
karlb
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
karlb
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
karlb
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
karlb
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
karlb
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
karlb
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Port the block limit per fee currency feature Closes #65 This implements the block-limit per fee-currency feature. Some parts of this have been directly ported from celo-blockchain (celo-org/celo-blockchain@dc45bdc00). * Copy MultiGasPool in miner environment * Add USDT and USDC to block-limit per currency defaults * Initialize MultiGasPool with currency whitelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65
This implements the block-limit per fee-currency feature.
Some parts of this have been directly ported from celo-blockchain
(celo-org/celo-blockchain@dc45bdc00).