-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supplement baseFee and gasLimit for pre gingerbread blocks #302
Supplement baseFee and gasLimit for pre gingerbread blocks #302
Conversation
…rbreadBlockBaseFee"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kourin1996, looks good overall, but I don't see a reason to store the gas limit in the database, when we have it hardcoded. So I would just store the base fee.
Also how did you get your benchmark results? https://github.com/celo-org/celo-blockchain-planning/issues/384#issuecomment-2553929355
Set up a local cluster using |
…lds-in-rpc-pre-gingerbread-block
Question regarding the general approach: we could also do those calculations during the migration right. That would trade some complexity there for simpler code in the codebase. Any opinions on that? |
The problem with that approach is that we are not syncing this data, so if we did that, snap sync nodes would not have it. So I think it's better to calculate it on demand as it is done here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @Kourin1996!
Closes https://github.com/celo-org/celo-blockchain-planning/issues/384
This PR adds
baseFeePerGas
andgasLimit
to the response of pre Gingerbread block in JSON-RPC