This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
forked from arkworks-rs/snark
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-chuang
force-pushed
the
jonch/mongrel
branch
from
November 7, 2020 06:47
ca4e6a9
to
07b37a9
Compare
jon-chuang
force-pushed
the
jonch/mongrel
branch
from
November 8, 2020 03:28
ead9475
to
06cc547
Compare
kobigurk
force-pushed
the
jonch/mongrel
branch
from
November 9, 2020 07:24
7aaecde
to
b508064
Compare
kobigurk
approved these changes
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes single function
cpu_gpu_scalar_mul
A majority of the PR lies in the
algebra/curves/cuda
folder (850 out of 1400 loc). There is a deletion ofsw_projective.rs
as it is not actually used anywhere and Pratyush mentioned he plans to drop it in future zexe. The rest of the diff is boilerplate to impl for different curves, or code displacement (300 loc). Also, there is a test.Potential TODOs:
GPUScalarMul
pub(crate)
instead ofpub
, and haveGPUScalarMulSlice
be the onlypub
.GPUScalarMulInternal
pub(crate)
and choose what to expose in publicGPUScalarMul
interface. (I prefer this).