Jetpack Compose Migration: WelcomeActivity #1692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! cc: @hussainmohd-a |
There was a problem hiding this comment.
The app now supports three themes: Light, Dark, and True Black. The theme is determined by the theme variable in PersistentState.kt
|
@hussainmohd-a this PR is ready for review, can you PTAL? :) |
VishnuSanal
changed the title
ping(reminder): @hussainmohd-a ;) |
@VishnuSanal , I have added some comments to the PR. Can you please take a look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @ignoramous, as mentioned IRL from the IndiaFOSS stall, I will start working on the migration to jetpack compose. I will migrate the welcome activity first to get started. what do you think?