Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Convert 500 http status code to trace status code Internal #1227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OmarElgabry
Copy link

@OmarElgabry OmarElgabry commented Sep 7, 2020

Is there any reason why we aren't converting http status code (500) to a trace.Status code? The http.StatusInternalServerError has a corresponding trace status code trace.StatusCodeInternal

@OmarElgabry OmarElgabry requested review from rakyll, rghetia and a team as code owners September 7, 2020 19:53
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@OmarElgabry
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 7, 2020
@OmarElgabry OmarElgabry changed the title Convert 500 http status code to trace.status Convert 500 http status code to trace status code Internal Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants