Improved error message on double registration #98
+128
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know track when we register a mats annotated bean, and detect double registration of the same class (but not the same endpoint, that is covered by Mats). This should only occur if you register the same class on the declaration level and in the method, or in the parent and nested tests. Also added test example of Mockito Added some extra life cycle tests for the Extension_MatsAnnotatedClass, the same criterias should hold true for jUnit, but it is a bit easier to test in Jupiter with nested classes. It mainly tests the Abstract class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, an example using Mockito.
I added some more tests, and it occurred to me that we might want to have a nice error message on duplicate registrations, in case you register both in a top class and a nested class. This would have failed in any case (and does not make sense imho.). The entire test suite uses 1 MatsFactory, so it is global for all tests.