Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for rate limits #1148

Merged
merged 2 commits into from
Dec 12, 2024
Merged

add docs for rate limits #1148

merged 2 commits into from
Dec 12, 2024

Conversation

bpal938
Copy link
Contributor

@bpal938 bpal938 commented Dec 11, 2024 •
edited
Loading

This adds new docs to explain our rate limits at a high level.

Test Plan:

image image

@bpal938 bpal938 force-pushed the feat/add-rate-limit-guides branch from 741f41a to eae9472 Compare December 12, 2024 00:00
laurencemcknight
laurencemcknight approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@laurencemcknight laurencemcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to fix the integration test but other than that LGTM.

@bpal938 bpal938 force-pushed the feat/add-rate-limit-guides branch from eae9472 to a2cb722 Compare December 12, 2024 00:31
@bpal938 bpal938 force-pushed the feat/add-rate-limit-guides branch from a2cb722 to 7a5c382 Compare December 12, 2024 00:32
Ray2126
Ray2126 approved these changes Dec 12, 2024
View reviewed changes
src/content/api/http-status-codes.mdoc Show resolved Hide resolved
src/content/api/rate-limits.mdoc Show resolved Hide resolved
@bpal938 bpal938 merged commit c5843df into master Dec 12, 2024
8 checks passed
@bpal938 bpal938 deleted the feat/add-rate-limit-guides branch December 12, 2024 01:18
@bpal938 bpal938 mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurencemcknight laurencemcknight laurencemcknight approved these changes

@Ray2126 Ray2126 Ray2126 approved these changes

@subarashii-huch09 subarashii-huch09 Awaiting requested review from subarashii-huch09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpal938 @Ray2126 @laurencemcknight