Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idempotencyKey field to pay a payment request API #1152

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

subarashii-huch09
Copy link
Contributor

@subarashii-huch09 subarashii-huch09 commented Dec 22, 2024

idempotencyKey is a new field that is required for the pay payment request API. This will allow integrators to safely retry failed requests without incurring duplicate charges.

Changes made

Screenshot 2024-12-23 at 12 33 20 PM

@subarashii-huch09 subarashii-huch09 assigned Ray2126 and unassigned Ray2126 Dec 22, 2024
@subarashii-huch09 subarashii-huch09 marked this pull request as ready for review December 22, 2024 23:58
@Ray2126
Copy link
Contributor

Ray2126 commented Dec 22, 2024

@subarashii-huch09 Were you planning to document our idempotency behaviour in a separate PR?

@subarashii-huch09
Copy link
Contributor Author

subarashii-huch09 commented Dec 23, 2024

@subarashii-huch09 Were you planning to document our idempotency behaviour in a separate PR?

@Ray2126 🙋🏻‍♀️ Were you thinking to create a dedicated "Idempotency" section - similar to how Stripe does it ?
Screenshot 2024-12-23 at 2 56 36 PM

@Ray2126
Copy link
Contributor

Ray2126 commented Dec 23, 2024

@subarashii-huch09 Yes, clients need to know what our APIs respond with in order to handle responses appropriately.

@subarashii-huch09
Copy link
Contributor Author

@subarashii-huch09 Yes, clients need to know what our APIs respond with in order to handle responses appropriately.

@Ray2126 I will include our idempotency behaviour in this PR : )

@subarashii-huch09 subarashii-huch09 marked this pull request as draft December 23, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants