Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft page #782

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Draft page #782

merged 1 commit into from
Oct 2, 2023

Conversation

AndyClifford
Copy link
Contributor

@AndyClifford AndyClifford commented Oct 2, 2023 •
edited
Loading

Created a wrapper function for getCollection which does not return any draft pages when in production. This allows us to incrementally migrate the legacy API reference.

Ticket: https://www.notion.so/centrapay/Create-a-draft-Astro-page-b39e82f4a15a41ef8b34c41fa45d54d3?pvs=4

Test Plan:

The draft page shows up in DEV mode
image

@AndyClifford AndyClifford marked this pull request as draft October 2, 2023 00:49
@AndyClifford AndyClifford force-pushed the draft-page branch 5 times, most recently from d5203a0 to 6a50523 Compare October 2, 2023 02:57
@AndyClifford AndyClifford marked this pull request as ready for review October 2, 2023 03:06
@AndyClifford
Draft pages
2c67201 
Created a wrapper function for getCollection which does not return any draft pages when in production. This allows us to incrementally migrate the legacy API reference
AndyClifford
AndyClifford commented Oct 2, 2023
View reviewed changes
build.sh Show resolved Hide resolved
@AndyClifford AndyClifford merged commit f923a20 into master Oct 2, 2023
1 check passed
@AndyClifford AndyClifford deleted the draft-page branch October 2, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeganSteenkamp MeganSteenkamp MeganSteenkamp approved these changes

@alexBinns alexBinns Awaiting requested review from alexBinns

@tom-blake tom-blake Awaiting requested review from tom-blake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyClifford @tom-blake @MeganSteenkamp