🐛 Fix side nav #792
Merged
🐛 Fix side nav #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeganSteenkamp
requested review from
Neeraj-Ghodla,
AndyClifford and
alexBinns
Neeraj-Ghodla
approved these changes
Oct 4, 2023
There was a small UI bug where we were conditionally adding the API section for draft pages. In production this was leaving a small hoverable element because the undefined variable in the array was still iterated over to create a UI element. Test plan: * Expect visual regression to be fixed in production. * Expect draft pages to be available in development.
MeganSteenkamp
force-pushed
the
fix-side-nav
branch
from
b6e3ac1 to
935ec7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small UI bug where we were conditionally adding the API section for draft pages. In production this was leaving a small hoverable element because the undefined variable in the array was still iterated over to create a UI element.
Test plan: