Detect if new changes break existing links #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MeganSteenkamp @tom-blake just been playing around with this - do you think it's necessary? I think it should only run on the production build but this is difficult as the |
AndyClifford
force-pushed
the
no-broken-links
branch
2 times, most recently
from
a37a2dc to
2ca57e4
Compare
It would be nice to have to get some extra confidence as long as it doesn't take too much time to make :) Perhaps running on the development build is ok? |
tom-blake
reviewed
Oct 8, 2023
AndyClifford
force-pushed
the
no-broken-links
branch
6 times, most recently
from
ee66876 to
9401ba3
Compare
AndyClifford
force-pushed
the
no-broken-links
branch
from
9401ba3 to
6558ace
Compare
tom-blake
reviewed
Oct 9, 2023
AndyClifford
force-pushed
the
no-broken-links
branch
3 times, most recently
from
9cd8d2d to
c85b0e8
Compare
tom-blake
reviewed
Oct 10, 2023
tom-blake
reviewed
Oct 10, 2023
tom-blake
approved these changes
Oct 10, 2023
Added a unit test which determines if any static links have been broken by iterating over the build output and comparing it to a snapshot of existing links. The test will fail if a page is removed and no redirect is added for it.
AndyClifford
force-pushed
the
no-broken-links
branch
from
c85b0e8 to
7facfb5
Compare
AndyClifford
force-pushed
the
no-broken-links
branch
from
7facfb5 to
7519dad
Compare
AndyClifford
force-pushed
the
no-broken-links
branch
from
7519dad to
2c6dc9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a unit test which determines if any static links have been broken by iterating over the build output and comparing it to a snapshot of existing links. The test will fail if a page is removed and no redirect is added for it.
This allows us to migrate the legacy docs site to the new astro site with confidence. Also ensures we add the existing legacy redirects to the new astro redirects once we publish the migration
Test Plan: