404 Page #796
Merged
404 Page #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neeraj-Ghodla
approved these changes
Oct 5, 2023
|
@AndyClifford would be good to get a design review on this ❤️ |
| <p class="text-content-accent type-body-2 font-bold"> | ||
| 404 | ||
| </p> | ||
| <h1 class="type-headline-2 text-gray-900"> |
There was a problem hiding this comment.
I think this should be a custom Centrapay colour token next time 👀
There was a problem hiding this comment.
Do you have a suggestion for which one to use? Looks like there's a few cases of text-gray-*
| <button | ||
| id="freshdesk" | ||
| type="button" | ||
| class="btn bg-interactive-tertiary border rounded-md" |
There was a problem hiding this comment.
@AndyClifford How does this work to open the freshdesk? I'm guessing it's from the id but ids should be unique on a page
There was a problem hiding this comment.
Yeah it is from the id - this has broken the original button when the 404 page is visible. Will look into this now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
404 Page as per the Figma design https://www.figma.com/file/IgRlQWJTyGoZhlF4fVKD6B/Centrapay-Docs-(Tailwind)?type=design&node-id=636-5747&mode=design&t=a1A4fYhOc8PuRO7Y-0
Reworded the text to match the Tailwind UI Protocol
Test Plan: