Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public response payloads for get asset and get asset transfers #797

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

seliwe
Copy link
Contributor

@seliwe seliwe commented Oct 5, 2023

getAsset and getAssetTranfer APIs will be modified to return a scoped-down public view of the entities for non-authorised callers. This is to support our publically available pages when viewing and claiming transfers via magic links.

Story: https://www.notion.so/centrapay/Create-public-APIs-to-retrieve-asset-transfer-details-d74ef85d65e14dcc881f66104adbbf08?pvs=4

Design docs:
https://www.notion.so/centrapay/Get-Asset-Summary-6ce7a29e23574ff19eead1053c6e1f15?pvs=4
https://www.notion.so/centrapay/Get-Asset-Transfer-Summary-6a334bba8e2148f8a1152df2b7710213?pvs=4

Copy link
Contributor

@subarashii-huch09 subarashii-huch09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@seliwe seliwe force-pushed the public-asset-endpoints branch from 64ceb18 to 88ef3c4 Compare October 10, 2023 22:37
@seliwe seliwe merged commit 5ca56d9 into master Oct 12, 2023
@seliwe seliwe deleted the public-asset-endpoints branch October 12, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants