Endpoint component #803
Merged
Endpoint component #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyClifford
commented
Oct 11, 2023
AndyClifford
force-pushed
the
endpoint-component
branch
from
dd92b3a to
5644ea5
Compare
AndyClifford
commented
Oct 11, 2023
AndyClifford
force-pushed
the
endpoint-component
branch
from
5644ea5 to
c6a80b7
Compare
|
What does it look like in mobile view? |
AndyClifford
force-pushed
the
endpoint-component
branch
from
c6a80b7 to
87a37df
Compare
AndyClifford
force-pushed
the
endpoint-component
branch
from
87a37df to
778f670
Compare
|
AndyClifford
force-pushed
the
endpoint-component
branch
from
778f670 to
8165c69
Compare
|
@AndyClifford we should get some input on the Jesters here too 🤡 |
AndyClifford
force-pushed
the
endpoint-component
branch
3 times, most recently
from
d649458 to
6abd616
Compare
AndyClifford
force-pushed
the
endpoint-component
branch
2 times, most recently
from
06fb283 to
3286785
Compare
AndyClifford
commented
Oct 13, 2023
AndyClifford
force-pushed
the
endpoint-component
branch
2 times, most recently
from
c86ae73 to
97c9a5c
Compare
@MeganSteenkamp I have checked in with Junjie and he is happy with the current layout |
AndyClifford
force-pushed
the
endpoint-component
branch
2 times, most recently
from
3c31d5c to
d9d07f1
Compare
AndyClifford
commented
Oct 15, 2023
AndyClifford
force-pushed
the
endpoint-component
branch
from
d9d07f1 to
d568a75
Compare
This change allows us to document api endpoints using the same layout as seen in the [Figma Design](https://www.figma.com/file/IgRlQWJTyGoZhlF4fVKD6B/Centrapay-Docs-(Tailwind)?type=design&node-id=1654-8412&mode=design&t=qTBa6bhBVBAMyHqN-0). There are issues with the styling such as the h2 header but we are just focussed on getting the layout correct then will followup with styling later once we have aligned with the designers.
AndyClifford
force-pushed
the
endpoint-component
branch
from
d568a75 to
2bea7fd
Compare
MeganSteenkamp
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to document api endpoints using markdoc using the same layout as seen in the Protocol Tailwind UI Example.
There are issues with the styling such as the h2 header being underlined but we are just focussed on getting the layout correct then will followup with styling later once we have aligned with the designers. The code block styling needs updating too.
Test Plan:
Desktop:
Mobile: