♻️ Show all active sections in table of contents #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeganSteenkamp
force-pushed
the
toc-show-all-active
branch
from
61defb7 to
37a9c83
Compare
Show all active sections as this will mean we can also show headings in our side navigation and the highlighted sections will be aligned. It removes the need to handle clicks when there are small sections at the bottom that have their anchor tags clicked. Related thread: https://centrapay.slack.com/archives/C04B93QUDSM/p1696994426728949 Story: ✨ [Migrate API Documentation](https://www.notion.so/centrapay/Lanterns-d784e8a5f9fa44328a5d0ae1fd85d37e?p=c6d64de29a2245358a5e9b7eed5edbcc&pm=s) Test plan: Expect multiple sections to be highlighted in TOC when they are all visible.
MeganSteenkamp
force-pushed
the
toc-show-all-active
branch
from
37a9c83 to
ddb0b9a
Compare
|
Closing due to design review - reverting to one active section at a time 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show all active sections as this will mean we can also show headings in our side navigation and the highlighted sections will be aligned. It removes the need to handle clicks when there are small sections at the bottom that have their anchor tags clicked.
Related thread: https://centrapay.slack.com/archives/C04B93QUDSM/p1696994426728949
Story: ✨ Migrate API Documentation
Test plan: Expect multiple sections to be highlighted in TOC when they are all visible.