Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental flag #808

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add experimental flag #808

merged 1 commit into from
Oct 17, 2023

Conversation

alexBinns
Copy link
Contributor

@alexBinns alexBinns commented Oct 13, 2023

This PR adds a badge astro component.

image
image
image

@MeganSteenkamp
Copy link
Contributor

@alexBinns we should get a design review on this 🙌
How does it look when it's on an endpoint title?

@alexBinns
Copy link
Contributor Author

@alexBinns we should get a design review on this 🙌 How does it look when it's on an endpoint title?

Yea I have posted in design-crit for jesters review

@alexBinns
Copy link
Contributor Author

@alexBinns we should get a design review on this 🙌 How does it look when it's on an endpoint title?

It looks the same pretty much. I can rebase off Andy's PR and add in there?

@AndyClifford
Copy link
Contributor

AndyClifford commented Oct 13, 2023

Looks great 🚀

  • How do we plan on using this in combination with a native markdown h2 i.e. ## Endpoint Title ...
  • Do you think it makes more sense to use a component which encapsulates the h2 (and experimental flag) using html? If so how will our site nav and/or TOC handle these?

@alexBinns
Copy link
Contributor Author

@alexBinns we should get a design review on this 🙌 How does it look when it's on an endpoint title?

image
image

@alexBinns alexBinns force-pushed the experimental-tag branch 2 times, most recently from e726f89 to e1ddd5a Compare October 16, 2023 02:40
@alexBinns
Copy link
Contributor Author

I have updated it to a flex that will drop down to a new line instead of hover at the right side screenshots below. I spoke to Junjie. He said it is preferable to having it hover on the right side.
image
image
image

@alexBinns alexBinns merged commit c78750e into master Oct 17, 2023
1 check passed
@alexBinns alexBinns deleted the experimental-tag branch October 17, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants