Restyle API reference headings #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyClifford
commented
Oct 16, 2023
MeganSteenkamp
approved these changes
Oct 16, 2023
Created a custom Prose wrapper for the api reference content which restyles the h2 and h3 headings to match the [Figma Design](https://www.figma.com/file/IgRlQWJTyGoZhlF4fVKD6B/Centrapay-Docs-\(Tailwind\)\?type\=design\&node-id\=1750-597\&mode\=design\&t\=3A8yZ1mxo93ITrUc-0).
AndyClifford
force-pushed
the
api-reference-h2
branch
from
2278f6d to
75a4a94
Compare
MeganSteenkamp
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created custom H2 and H3 components for the api reference content to match the Figma Design.
Note: Junjie is happy with the design though we noticed that the headings across our entire docs site do not exactly match what is seen in Figma even though we are using the same styles. The main issue is the headings are a lot bolder in Figma so maybe there is a mismatch going on somewhere 🤔 I have added a task to investigate this.
Test Plan:
Desktop:
Mobile: