Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate accounts page #813

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Migrate accounts page #813

merged 1 commit into from
Oct 17, 2023

Conversation

AndyClifford
Copy link
Contributor

@AndyClifford AndyClifford commented Oct 17, 2023

Migrated the accounts API reference page to the new astro site in draft mode. Will deploy each page to dev for people to have a look at instead of posting screenshots as the pages are quite long

Ticket: https://www.notion.so/centrapay/Migrate-API-Documentation-c6d64de29a2245358a5e9b7eed5edbcc?pvs=4

Test Plan:

@AndyClifford
Copy link
Contributor Author

AndyClifford commented Oct 17, 2023

@MeganSteenkamp @alexBinns This is what the get account endpoint looks like with no attributes section. What do you guys think?

I think it looks better as long as there is an endpoint description. It also means devs don't have to worry about adding No Attributes for these endpoints. Happy to keep as is though.

image

@alexBinns
Copy link
Contributor

tter as long as there is an endpoint description. It also means devs don't have to worry about adding No Attributes for these endpoints. Happy to keep as is though.

I feel for consitancy that we should specify no attributes and it will be less likely to cause confusion

@AndyClifford AndyClifford force-pushed the migrate-accounts-page branch from 4de49e9 to 4d2cd82 Compare October 17, 2023 02:39
@AndyClifford AndyClifford force-pushed the migrate-accounts-page branch from 4d2cd82 to 4aae2cb Compare October 17, 2023 02:43
@AndyClifford AndyClifford merged commit 2425b8a into master Oct 17, 2023
@AndyClifford AndyClifford deleted the migrate-accounts-page branch October 17, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants