🐛 Fix endpoint layout #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeganSteenkamp
commented
Oct 18, 2023
tom-blake
reviewed
Oct 18, 2023
Remark plugin was causing sections to be rendered before slots were used, which was affecting our layout. Change to use a rehype plugin so HTML is transformed instead of transforming MDX. Test plan: Expect guides layout and table of contents to be unaffected.
MeganSteenkamp
force-pushed
the
fix-endpoint-layout
branch
from
5440536 to
580fd75
Compare
AndyClifford
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remark plugin was causing sections to be rendered before slots were used, which was affecting our layout. Change to use a rehype plugin so HTML is transformed instead of transforming MDX.
Test plan: Expect guides layout and table of contents to be unaffected.