-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't automatically rebuild EUROMODpolicySchedule file and check for valid file. #45
Don't automatically rebuild EUROMODpolicySchedule file and check for valid file. #45
Conversation
Hi @pbronka - have tested this out and it should work smoothly to fix my accidentally introduced bug.
This will mean that it defaults to false - not overwriting the 'EUROMODpolicySchedule.xlsx' file. But I've added a check to see if the file exists and exit with message if both missing and no-rewrite. The rewrite option ( This pull request also makes some small additional changes:
As an aside, I think a potential wiki page could cover "Customising your SimPaths run" to outline best practices for using features to make SimPaths fit user purpose (summarising the above bit clearly and adding in other parts such as customising config file). I'll aim to make a draft at some point. |
Thank you @andrewbaxter439 . A wiki page sounds like a great idea to me. I'm not sure if you can currently edit it - if not, please let me know and we will figure it out. |
As a brief side point - apologies @pbronka if you get a stream of notification emails every time I do a pull request with a GitHub Actions run that fails! I might start test-pull-requests to my own repo first as they can get quite annoying if they keep crashing! |
Closes #44 by adding an option to not rebuild Excel file and exit with error if no file found.