Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(purge): do not use deletion_time field in the comments deletion #11135

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

s-duret
Copy link
Contributor

@s-duret s-duret commented May 18, 2022

Description

Currently, the purge script deletes comments only in these two cases:

  • a retention duration is set AND the deletion time is older than the retention
  • a retention duration is set AND the expire time is older than the retention

Deletion time is set if we delete a comment from the GUI or if a downtime ends.

We need to change the condition and delete comments taking into account the entry time.

Fixes MON-13407

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.10.x
  • 21.04.x
  • 21.10.x
  • 22.04.x (master)

@s-duret s-duret requested review from a team, adr-mo and TamazC May 18, 2022 08:58
@quanghungb quanghungb requested a review from kduret September 29, 2022 07:41
@sonarqube-decoration
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants