cleanup(gorgone): Avoid double-rollback when db commit fails

centreon · Jul 27, 2024 · 0716eb2 · 0716eb2
1 parent d15b700
commit 0716eb2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/gorgone/gorgone/class/db.pm b/gorgone/gorgone/class/db.pm
@@ -202,9 +202,10 @@ sub commit {
     my $status = $self->{instance}->commit();
 
     if (!$status) {
-        $self->error($self->{instance}->errstr, 'commit');
+        # Note that the call to error() does a rollback, which is what we want
+        # in case of failure
         # https://stackoverflow.com/questions/24316603/why-should-i-rollback-after-failed-commit
-        self->rollback();
+        $self->error($self->{instance}->errstr, 'commit');
         return -1;
     }