no engine_otl_endpoint parameter in telegraf config (#1676)

centreon · Sep 6, 2024 · d883265 · d883265 · github-actions · Sep 10, 2024
1 parent cb70ed3
commit d883265
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 21 deletions.
diff --git a/engine/modules/opentelemetry/doc/otel_configuration.odg b/engine/modules/opentelemetry/doc/otel_configuration.odg
diff --git a/engine/modules/opentelemetry/doc/otel_configuration.pdf b/engine/modules/opentelemetry/doc/otel_configuration.pdf
diff --git a/...dules/opentelemetry/inc/com/centreon/engine/modules/opentelemetry/telegraf/conf_server.hh b/...dules/opentelemetry/inc/com/centreon/engine/modules/opentelemetry/telegraf/conf_server.hh
@@ -33,7 +33,6 @@ class conf_server_config {
   unsigned _second_keep_alive_interval;
   std::string _certificate_path;
   std::string _key_path;
-  std::string _engine_otl_endpoint;
   unsigned _check_interval;
 
  public:
@@ -54,9 +53,6 @@ class conf_server_config {
 
   const std::string& get_certificate_path() const { return _certificate_path; }
   const std::string& get_key_path() const { return _key_path; }
-  const std::string& get_engine_otl_endpoint() const {
-    return _engine_otl_endpoint;
-  }
 
   bool operator==(const conf_server_config& right) const;
 };

diff --git a/engine/modules/opentelemetry/src/telegraf/conf_server.cc b/engine/modules/opentelemetry/src/telegraf/conf_server.cc
@@ -77,16 +77,8 @@ static constexpr std::string_view _config_schema(R"(
             "description": "interval in seconds between two checks (param [agent] interval) ",
             "type": "integer",
             "minimum": 10
-        },
-        "engine_otel_endpoint": {
-            "description": "opentelemetry engine grpc server",
-            "type": "string",
-            "minLength": 5
         }
     },
-    "required":[
-      "engine_otel_endpoint"
-    ],
     "type": "object"
 }
 )");
@@ -105,7 +97,6 @@ conf_server_config::conf_server_config(const rapidjson::Value& json_config_v,
     throw;
   }
 
-  _engine_otl_endpoint = json_config.get_string("engine_otel_endpoint");
   _check_interval = json_config.get_unsigned("check_interval", 60);
 
   if (json_config_v.HasMember("http_server")) {
@@ -396,12 +387,8 @@ void conf_session<connection_class>::answer_to_request(
   ## Default data collection interval for all inputs
   interval = "{}s"
 
-[[outputs.opentelemetry]]
-  service_address = "{}"
-
 )",
-                             _telegraf_conf->get_check_interval(),
-                             _telegraf_conf->get_engine_otl_endpoint());
+                             _telegraf_conf->get_check_interval());
   bool at_least_one_found = _get_commands(host, resp->body());
   if (at_least_one_found) {
     resp->result(boost::beast::http::status::ok);

diff --git a/tests/resources/opentelemetry/telegraf.conf b/tests/resources/opentelemetry/telegraf.conf
@@ -4,9 +4,6 @@
   ## Default data collection interval for all inputs
   interval = "60s"
 
-[[outputs.opentelemetry]]
-  service_address = "127.0.0.1:4317"
-
 
 [[inputs.exec]]
   name_override = "otel_check_icmp_host_1"