Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-15765 semicolon is not considered as a beginning of comment in engine configuration file #1008

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

jean-christophe81
Copy link
Contributor

REFS:MON-15765

semicolon ; is not a delimiter for comments in engine configuration files

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@jean-christophe81 jean-christophe81 marked this pull request as ready for review December 14, 2023 18:39
@jean-christophe81 jean-christophe81 requested review from a team as code owners December 14, 2023 18:39
@bouda1 bouda1 requested review from sdepassio and lucie-dubrunfaut and removed request for thearchit3ct February 6, 2024 11:52
@bouda1 bouda1 merged commit a206045 into develop Feb 22, 2024
12 checks passed
@bouda1 bouda1 deleted the MON-15765_manage_macros_values_including_semicolon branch February 22, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants