Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): replace job conditional by dedicated step #1169

Merged
merged 5 commits into from
Mar 4, 2024
Merged

fix(ci): replace job conditional by dedicated step #1169

merged 5 commits into from
Mar 4, 2024

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Feb 29, 2024 •
edited
Loading

Description

Fix job conditional
add missing elements

Fixes #MON-34069

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

@tuntoja tuntoja requested a review from a team as a code owner February 29, 2024 13:29
@tuntoja tuntoja requested review from kduret and sc979 February 29, 2024 13:29
@tuntoja tuntoja requested review from kduret and sc979 March 1, 2024 08:38
@tuntoja tuntoja merged commit f2645fe into develop Mar 4, 2024
2 checks passed
@tuntoja tuntoja deleted the MON-34069-rework-release-communications-2 branch March 4, 2024 14:33
tuntoja added a commit that referenced this pull request Mar 4, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
599bfb5 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 5, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
1133579 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 5, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
62b9634 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 5, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
e579525 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 5, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
9ba5c69 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 5, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
d18f2a2 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 5, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
f9687c9 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 5, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
57730a6 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 7, 2024
@tuntoja @mushroomempires
@sc979 @kduret
feat(ci): rework release workflow and communications (#1187)
8002920 
* feat(ci): rework release workflow and communications (#1096)

* feat(ci): rework release workflow and communications

* add action and new release action

* remove old release-collect file

* fix

* fix

* fix

* update release workflow

* fix

* Update .github/actions/release/action.yml

Co-authored-by: May <[email protected]>

* Update .github/actions/release/action.yml

Co-authored-by: Stéphane Chapron <[email protected]>

* fix feedbacks round 1

* rebuild json data

* test

* test

* Revert "test"

This reverts commit 366a354.

* Revert "Revert "test""

This reverts commit 3ee3582.

* more tests

* more tests

* review

* handle feedbacks 2

* add feedback

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>

* fix(ci): replace job conditional by dedicated step (#1169)

* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>
Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 7, 2024
@tuntoja @mushroomempires
@sc979 @kduret
feat(ci): rework release workflow and communications (#1186)
52ab1fd 
* feat(ci): rework release workflow and communications (#1096)

* feat(ci): rework release workflow and communications

* add action and new release action

* remove old release-collect file

* fix

* fix

* fix

* update release workflow

* fix

* Update .github/actions/release/action.yml

Co-authored-by: May <[email protected]>

* Update .github/actions/release/action.yml

Co-authored-by: Stéphane Chapron <[email protected]>

* fix feedbacks round 1

* rebuild json data

* test

* test

* Revert "test"

This reverts commit 366a354.

* Revert "Revert "test""

This reverts commit 3ee3582.

* more tests

* more tests

* review

* handle feedbacks 2

* add feedback

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>

* fix(ci): replace job conditional by dedicated step (#1169)

* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>
Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 7, 2024
@tuntoja @mushroomempires
@sc979 @kduret
feat(ci): rework release workflow and communications (#1185)
e052d8b 
* feat(ci): rework release workflow and communications (#1096)

* feat(ci): rework release workflow and communications

* add action and new release action

* remove old release-collect file

* fix

* fix

* fix

* update release workflow

* fix

* Update .github/actions/release/action.yml

Co-authored-by: May <[email protected]>

* Update .github/actions/release/action.yml

Co-authored-by: Stéphane Chapron <[email protected]>

* fix feedbacks round 1

* rebuild json data

* test

* test

* Revert "test"

This reverts commit 366a354.

* Revert "Revert "test""

This reverts commit 3ee3582.

* more tests

* more tests

* review

* handle feedbacks 2

* add feedback

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>

* fix(ci): replace job conditional by dedicated step (#1169)

* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>
Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 7, 2024
@tuntoja @mushroomempires
@sc979 @kduret
feat(ci): rework release workflow and communications (#1184)
2f0d5dd 
* feat(ci): rework release workflow and communications (#1096)

* feat(ci): rework release workflow and communications

* add action and new release action

* remove old release-collect file

* fix

* fix

* fix

* update release workflow

* fix

* Update .github/actions/release/action.yml

Co-authored-by: May <[email protected]>

* Update .github/actions/release/action.yml

Co-authored-by: Stéphane Chapron <[email protected]>

* fix feedbacks round 1

* rebuild json data

* test

* test

* Revert "test"

This reverts commit 366a354.

* Revert "Revert "test""

This reverts commit 3ee3582.

* more tests

* more tests

* review

* handle feedbacks 2

* add feedback

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>

* fix(ci): replace job conditional by dedicated step (#1169)

* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>
Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 7, 2024
@tuntoja @mushroomempires
@sc979 @kduret
feat(ci): rework release workflow and communications (#1183)
8ba9e93 
* feat(ci): rework release workflow and communications (#1096)

* feat(ci): rework release workflow and communications

* add action and new release action

* remove old release-collect file

* fix

* fix

* fix

* update release workflow

* fix

* Update .github/actions/release/action.yml

Co-authored-by: May <[email protected]>

* Update .github/actions/release/action.yml

Co-authored-by: Stéphane Chapron <[email protected]>

* fix feedbacks round 1

* rebuild json data

* test

* test

* Revert "test"

This reverts commit 366a354.

* Revert "Revert "test""

This reverts commit 3ee3582.

* more tests

* more tests

* review

* handle feedbacks 2

* add feedback

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>

* fix(ci): replace job conditional by dedicated step (#1169)

* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>
Co-authored-by: Kevin Duret <[email protected]>
tuntoja added a commit that referenced this pull request Mar 19, 2024
@tuntoja @mushroomempires
@sc979 @kduret
feat(ci): rework release workflow and communications (#1184)
88c8786 
* feat(ci): rework release workflow and communications (#1096)

* feat(ci): rework release workflow and communications

* add action and new release action

* remove old release-collect file

* fix

* fix

* fix

* update release workflow

* fix

* Update .github/actions/release/action.yml

Co-authored-by: May <[email protected]>

* Update .github/actions/release/action.yml

Co-authored-by: Stéphane Chapron <[email protected]>

* fix feedbacks round 1

* rebuild json data

* test

* test

* Revert "test"

This reverts commit 366a354.

* Revert "Revert "test""

This reverts commit 3ee3582.

* more tests

* more tests

* review

* handle feedbacks 2

* add feedback

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>

* fix(ci): replace job conditional by dedicated step (#1169)

* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>
Co-authored-by: Kevin Duret <[email protected]>
sfarouq-ext pushed a commit that referenced this pull request Apr 1, 2024
@tuntoja @kduret
fix(ci): replace job conditional by dedicated step (#1169)
b57b1fd 
* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>
bouda1 pushed a commit that referenced this pull request Jun 10, 2024
@tuntoja @mushroomempires
@sc979 @kduret @bouda1
feat(ci): rework release workflow and communications (#1187)
e774b66 
* feat(ci): rework release workflow and communications (#1096)

* feat(ci): rework release workflow and communications

* add action and new release action

* remove old release-collect file

* fix

* fix

* fix

* update release workflow

* fix

* Update .github/actions/release/action.yml

Co-authored-by: May <[email protected]>

* Update .github/actions/release/action.yml

Co-authored-by: Stéphane Chapron <[email protected]>

* fix feedbacks round 1

* rebuild json data

* test

* test

* Revert "test"

This reverts commit 366a354.

* Revert "Revert "test""

This reverts commit 3ee3582.

* more tests

* more tests

* review

* handle feedbacks 2

* add feedback

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>

* fix(ci): replace job conditional by dedicated step (#1169)

* udpate release workflow

* udpate release action

* add feedbacks

* Update .github/workflows/release.yml

Co-authored-by: Kevin Duret <[email protected]>

* Remove unused arrays

---------

Co-authored-by: Kevin Duret <[email protected]>

---------

Co-authored-by: May <[email protected]>
Co-authored-by: Stéphane Chapron <[email protected]>
Co-authored-by: Kevin Duret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mushroomempires mushroomempires mushroomempires approved these changes

@sc979 sc979 sc979 approved these changes

@kduret kduret kduret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuntoja @kduret @sc979 @mushroomempires