Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mon 35539 engine configuration manager telegraf #1202

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

jean-christophe81
Copy link
Contributor

@jean-christophe81 jean-christophe81 commented Mar 13, 2024

REFS:MON-35539

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch 4 times, most recently from 36c80a2 to 7a06da0 Compare March 21, 2024 07:34
@jean-christophe81 jean-christophe81 marked this pull request as ready for review March 21, 2024 09:08
@jean-christophe81 jean-christophe81 requested review from a team as code owners March 21, 2024 09:08
broker/core/src/main.cc Outdated Show resolved Hide resolved
engine/src/main.cc Outdated Show resolved Hide resolved
Copy link
Contributor

coderabbitai bot commented Mar 28, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch 4 times, most recently from 6cfd9b7 to bb9aa42 Compare April 4, 2024 09:10
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch from ce35b3c to bb9aa42 Compare April 29, 2024 09:36
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch 9 times, most recently from 771a21d to 6086bf9 Compare May 20, 2024 14:26
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch from 6086bf9 to 03a6b0e Compare May 23, 2024 13:47
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch 6 times, most recently from 0fc2698 to c73b269 Compare May 29, 2024 07:50
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch 8 times, most recently from 2acd526 to f854a48 Compare June 5, 2024 10:53
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch from f854a48 to a65f6f1 Compare June 5, 2024 12:26
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch 2 times, most recently from 19755e7 to 17fd701 Compare June 6, 2024 08:05
@jean-christophe81 jean-christophe81 force-pushed the MON-35539-engine-configuration_manager-telegraf branch from 17fd701 to 7f330f1 Compare June 6, 2024 10:03
@bouda1 bouda1 merged commit 5635b92 into develop Jun 6, 2024
413 of 415 checks passed
@bouda1 bouda1 deleted the MON-35539-engine-configuration_manager-telegraf branch June 6, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants