Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Engine configuration using protobuf #1541

Merged
merged 21 commits into from
Aug 30, 2024
Merged

New Engine configuration using protobuf #1541

merged 21 commits into from
Aug 30, 2024

Conversation

bouda1
Copy link
Collaborator

@bouda1 bouda1 commented Jul 17, 2024

REFS: MON-34072

@bouda1 bouda1 requested a review from a team as a code owner July 17, 2024 14:46
@bouda1 bouda1 requested a review from jean-christophe81 July 17, 2024 14:46
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bouda1 bouda1 requested a review from a team as a code owner July 17, 2024 16:10
@bouda1 bouda1 requested a review from Evan-Adam July 17, 2024 16:10
@bouda1 bouda1 force-pushed the MON-34072-new-protobuf-lib branch 4 times, most recently from d6b12e6 to eec4d04 Compare July 25, 2024 10:40
@bouda1 bouda1 force-pushed the MON-34072-new-protobuf-lib branch 11 times, most recently from 630193c to 922866b Compare August 8, 2024 12:57
@bouda1
enh(engine/configuration): First implementation of the common/engine_…
e975db2 
…conf library.

enh(engine/config): it compiles now

fix(common/engine_legacy): bug fixed in timeperiod configurations

REFS: MON-34072 MON-15480
@bouda1 bouda1 force-pushed the MON-34072-new-protobuf-lib branch from 3ad8f43 to 46b0acd Compare August 29, 2024 13:23
@bouda1 bouda1 force-pushed the MON-34072-new-protobuf-lib branch from 211bec1 to 90f2edc Compare August 30, 2024 08:18
bouda1 added 20 commits August 30, 2024 10:30
@bouda1
fix(common/engine_conf): various fixes after code review
4de577b 
* helper initializations better
* pb_difference works with pointers now.
* new comments also added.
* little fixes
* connector modify_object() and remove_object() had issues because of wrong backports
* method in timeperiod can return a reference
* comment updated for the set() method
* fill_(service[host)_notification_options mutualized
* parser has its array size fixed automatically
* new comments in the parser
* add_contact can be defined with moved addresses.
* timeperiod_helper _get_days_id() method rewritten with a map.
* timeperiod_helper _get_month_id() method rewritten with a map.

REFS: MON-34072 MON-15480
@bouda1
fix(broker/lua): Several fix in the lua Stream
d64dd0e 
* Legacy OpenSSL md5 function replaced by the OpenSSL 3 version
* improvement of hostgroups cache in streamconnector
* improvement of servicegroups cache in streamconnector

REFS: MON-34072 MON-15480
@bouda1
fix(broker/simu): compilation warning removed
c494cf1 
REFS: MON-34072 MON-15480
@bouda1
enh(broker/misc): Header file reformatted
b133f5a 
REFS: MON-34072 MON-15480
@bouda1
enh(broker/neb): fixes in the neb stream
16e6e6d 
* Integration of the new protobuf engine configuration
* bug on hostgroups handling fixed
* bug on servicegroups handling fixed

REFS: MON-34072 MON-15480
@bouda1
fix(broker/rebuilder): values are floats and not doubles and some tra…
a1d76aa 
…ce logs are added

REFS: MON-34072 MON-15480
@bouda1
fix(broker/victoria_metrics): warning removed
efd6abe 
REFS: MON-34072 MON-15480
@bouda1
cleanup(broker/core): little improvement to follow new standard
ce0e57b 
REFS: MON-34072 MON-15480
@bouda1
enh(broker): HostDependencies and ServiceDependencies are not used by…
10e9436 
… broker.

REFS: MON-34072 MON-15480
@bouda1
enh(engine/tests): unit tests are migrated to also work with the prot…
0148da5 
…obuf configuration

REFS: MON-34072 MON-15480
@bouda1
fix(tests/bam): test simplified
3696ef2 
REFS: MON-34072 MON-15480
@bouda1
enh(tests): hostgroups tests are more complete
625c643 
REFS: MON-34072 MON-15480
@bouda1
fix(tests): external-commands2 fixed
15504a6 
REFS: MON-34072 MON-15480
@bouda1
fix(tests/opentelemetry): current tests on opentelemetry have an issu…
410b31b 
…e with last_check

This is due to the fact that checks are seen as active on Engine. To fix this, we must to switch to passive checks for OTL checks.

REFS: MON-34072 MON-15480
@bouda1
enh(tests): hostgroups/servicegroups more complete
afd52d5 
REFS: MON-34072 MON-15480
@bouda1
fix(tests): severities tests were broken because name must be replace…
6583be8 
…d by severity_name

REFS: MON-34072 MON-15480
@bouda1
fix(tests): an issue with start date of tests is fixed, the duplicate…
fce8973 
… test is also rewritten because of strange values on my laptop

REFS: MON-34072 MON-15480
@bouda1
fix(tests): One index can return several metrics
9d35964 
We could in some cases have several times the same index returned because one index can contain several
metrics. And if an index points to several metrics, we must prepare all the metrics correctly otherwise
tests fail.

REFS: MON-34072 MON-15480
@bouda1
doc(tests): README updated
0392a93 
REFS: MON-34072 MON-15480
@bouda1
doc(common): a little explanation on the new engine_conf module
0db7a54 
REFS: MON-34072 MON-15480
@bouda1 bouda1 force-pushed the MON-34072-new-protobuf-lib branch from 90f2edc to 0db7a54 Compare August 30, 2024 08:30
@bouda1 bouda1 merged commit 6ae97cf into develop Aug 30, 2024
414 of 415 checks passed
@bouda1 bouda1 deleted the MON-34072-new-protobuf-lib branch August 30, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-christophe81 jean-christophe81 jean-christophe81 approved these changes

@Evan-Adam Evan-Adam Awaiting requested review from Evan-Adam Evan-Adam is a code owner automatically assigned from centreon/owners-robot-e2e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouda1 @jean-christophe81