-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MON-106121-gorgone-use-vault-autonomous-library #1791
MON-106121-gorgone-use-vault-autonomous-library #1791
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
66c2de2
to
b9ad762
Compare
0461adf
to
14f681b
Compare
74196f4
to
43e794d
Compare
Refs:MON-106121
…it tests. I didn't link to the template used by package installation because it can change (this have more configuration by the way) and I don't want to be sure the package install the correct file, I want to be sure gorgone read configuration correctly. Refs:MON-106121
Still need to add the vault feature and fix the tests for it, maybe add another vault jey in the big configuration Refs:MON-106121
Refs:MON-106121
We need to be sure the test modified still work. Refs:MON-106121
…r vault. Refs:MON-106121
Refs:MON-106121
Refs:MON-106121
Refs:MON-106121
Refs:MON-106121
Refs:MON-106121
The library is now in perl-libs/lib/centreon/common/logger.pm and available from centreon-perl-libs-common package. Refs:MON-106121
3827d3c
to
b1e81e6
Compare
Refs:MON-106121
The automated test should pass before we try to deliver the deb/rpm package. This is for now not backported because the tests are still new. Refs:MON-106121
Refs:MON-106121
Refs:MON-106121
Co-authored-by: omercier <[email protected]>
Co-authored-by: cg-tw <[email protected]>
Description
Add centreonvault dependancy and use it to retrieve all secret in the gorgone conf with a vault API.
Fixes # MON-106121
Type of change
Target serie
How this pull request can be tested ?
check gorgone can still be launched and correctly write it's log to the log file (start the service, check the log for any error, there should not be any)
configure vault and change one of gorgone property for a secret. The secret should be correctly retrieved from the vault.
Checklist