Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mon-21110 project structure #851

Closed
wants to merge 36 commits into from
Closed

Conversation

thearchit3ct
Copy link
Contributor

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 21.10.x
  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@thearchit3ct thearchit3ct self-assigned this Aug 23, 2023
@thearchit3ct thearchit3ct force-pushed the MON-21110-Project-Structure branch from 0480fca to 6763fb3 Compare September 5, 2023 05:10
@centreon centreon deleted a comment from github-actions bot Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
400 23 0 423 94.56

Failed Tests

Name Message ⏱️ Duration Suite
EBDP1 ((4,),) != () 86.481 s Delete-Poller
BEHOSTCHECK hosts table not updated 35.932 s External-Commands2
not1 check_for_external_commands() should be available. 90.258 s Notification
not2 check_for_external_commands() should be available. 90.426 s Notification
not3 check_for_external_commands() should be available. 60.395 s Notification
not4 check_for_external_commands() should be available. 60.39 s Notification
not5 check_for_external_commands() should be available. 60.403 s Notification
not6 check_for_external_commands() should be available. 60.4 s Notification
not7 An Initial host state on host_1 should be raised before we can start our external commands. 60.388 s Notification
not8 An Initial host state on host_1 should be raised before we can start our external commands. 60.38 s Notification
not9 An Initial host state on host_1 should be raised before we can start our external commands. 60.398 s Notification
not10 An Initial host state on host_1 should be raised before we can start our external commands. 60.403 s Notification
not11 An Initial host state on host_1 should be raised before we can start our external commands. 60.395 s Notification
not12 check_for_external_commands() is not available. 60.395 s Notification
not13 check_for_external_commands() is not available. 60.426 s Notification
BERDUC3U1 There are events sent several times, see /tmp/lua-engine.log and /tmp/lua.log 55.731 s Retention-Duplicates
ENRSCHE1 the delta of last_check and next_check is not equal to 60. 250 s Scheduler
BSCSSK1 No message about the bad connection. 31.111 s Bbdo-Server-Client-Ko
EFHC1 Message about SCHEDULE FORCED CHECK and HOST ALERT should be available in log. 87.896 s Forced Checks
EFHC2 Message about SCHEDULE FORCED CHECK and HOST ALERT should be available in log. 91.743 s Forced Checks
EFHCU1 Message about SCHEDULE FORCED CHECK and HOST ALERT should be available in log. 90.21 s Forced Checks
EFHCU2 Message about SCHEDULE FORCED CHECK and HOST ALERT should be available in log. 86.355 s Forced Checks
EMACROS_NOTIF An Initial host state on host_1 should be raised before we can start our external commands. Also teardown failed: Several failures occurred: 1) Invalid IF condition: Evaluating expression 'docker is None' failed: NameError: name 'docker' is not defined nor importable as module Variables in the original expression '${docker_env} is None' were resolved before the expression was evaluated. Try using '$docker_env is None' syntax to avoid that. See Evaluating Expressions appendix in Robot Framework User Guide for more details. 2) Engine badly stopped with 1 instances - code returned 1. 69.814 s Forced Checks

thearchit3ct and others added 7 commits October 6, 2023 16:41
* enh(broker):feeder don t user a thread and muxer provides asynchronous read

* fix(broker): remove timer cancel error message and fix map_client_types.py

* fix(broker): correction after rebase

* enh(broker):improve feeder

* fix(test): rrd and bench

* fix(broker): muxer::update_stats not always protected

* fix(test):bulk test

* fix(test): services-and-bulk-stmt.robot

* fix(test): test review comments

* enh(broker): feeder don't use shared_mutex

* enh(broker): improve feeder and muxer

* fix(broker):stmt_span::~stmt_span may make broker core if state was unload before

* enh(broker): muxer::write and engine::publish use a deque instead of list

* fix(test): test review comments

* add muxer trace

* fix(broker): muxer::publish protect
REFS:MON-16533
* fix(bam):mod_bam_reporting_relations_ba_bv is filled (#873)

* fix(bam):mod_bam_reporting_relations_ba_bv is filled

* fix(github): replace checkout@v3 by checkout@v4
REFS:MON-21335
REFS:MON-21390
* fix(test): add missing broker function
@thearchit3ct thearchit3ct force-pushed the MON-21110-Project-Structure branch from 10630b7 to d0973dd Compare October 6, 2023 15:07
@thearchit3ct thearchit3ct marked this pull request as ready for review December 7, 2023 14:39
@thearchit3ct thearchit3ct requested review from a team as code owners December 7, 2023 14:39
@thearchit3ct
Copy link
Contributor Author

The PR has been redrawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants