Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MON-22575] [Plugin] centreon-plugin-Hardware-Ups-Standard-Rfc1628-Snmp mode input-lines, no perfdata and thresholds when value equal 0 #4751

Merged
merged 13 commits into from
Dec 11, 2023
Merged

[MON-22575] [Plugin] centreon-plugin-Hardware-Ups-Standard-Rfc1628-Snmp mode input-lines, no perfdata and thresholds when value equal 0 #4751

merged 13 commits into from
Dec 11, 2023

Conversation

lucie-dubrunfaut
Copy link
Contributor

@lucie-dubrunfaut lucie-dubrunfaut commented Nov 27, 2023 •
edited
Loading

Description

  • Display thresholds when values are equal 0
  • Add exclude-id filter to to exclude some ID in the result
  • Add robot test to test non regression in this development features and fixes

Fixes # (issue)
#4671

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

Lucie Dubrunfaut and others added 13 commits November 27, 2023 09:57
Fix perfdata when value equal 0 and add exclude id filter
e744662
Add Ressources and Functionnal test for ups-standard
b2100e2
Add recursive copy
feab2ad
Wip
40c7ad7
Wip
9cb7559
Wip
31e7b15
@lucie-dubrunfaut
Update hardware-ups-standard-snmp.robot
e204983
Wip
3d5044f
Merge branch 'MON-22575-plugin-centreon-plugin-hardware-ups-standard-…
28134e3 
…rfc-1628-snmp-mode-input-lines-no-perfdata-and-thresholds-when-value-equal-0' of github.com:centreon/centreon-plugins into MON-22575-plugin-centreon-plugin-hardware-ups-standard-rfc-1628-snmp-mode-input-lines-no-perfdata-and-thresholds-when-value-equal-0
Wip
35d6b68
Update Robot test
208014a
Wip
b87fdf9
Add 3 exclude option tests
354c1eb
@lucie-dubrunfaut lucie-dubrunfaut marked this pull request as ready for review November 30, 2023 17:30
@lucie-dubrunfaut lucie-dubrunfaut requested review from a team as code owners November 30, 2023 17:30
@omercier omercier merged commit a19941e into develop Dec 11, 2023
11 checks passed
@omercier omercier deleted the MON-22575-plugin-centreon-plugin-hardware-ups-standard-rfc-1628-snmp-mode-input-lines-no-perfdata-and-thresholds-when-value-equal-0 branch December 11, 2023 09:19
omercier pushed a commit that referenced this pull request Jan 8, 2024
@lucie-dubrunfaut @omercier
[MON-22575] [Plugin] centreon-plugin-Hardware-Ups-Standard-Rfc1628-Sn…
5206397 
…mp mode input-lines, no perfdata and thresholds when value equal 0 (#4751)

Co-authored-by: Lucie Dubrunfaut <ldubrunfaut@CNTR-P-PF3DNAR1>
This was referenced Jun 28, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdepassio sdepassio sdepassio approved these changes

@tuntoja tuntoja tuntoja approved these changes

@sc979 sc979 sc979 approved these changes

@thearchit3ct thearchit3ct thearchit3ct approved these changes

@bouda1 bouda1 Awaiting requested review from bouda1 bouda1 is a code owner automatically assigned from centreon/owners-robot-e2e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lucie-dubrunfaut @thearchit3ct @sc979 @tuntoja @sdepassio @omercier