Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meraki-restapi): fix cisco meraki vpn-tunnels mode #5384

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

omercier
Copy link
Contributor

@omercier omercier commented Jan 10, 2025

Description

Replaces #5283 by @garnier-quentin

Use the right attributes for VPN statuses.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Tests modified.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
    • Data used for automated tests are anonymized.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences end with a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier requested review from a team as code owners January 10, 2025 11:12
@omercier omercier force-pushed the CTOR-1086-meraki-fix-vpn-tunnels branch from 362e165 to e105956 Compare January 10, 2025 12:07
@omercier omercier requested a review from sdepassio January 10, 2025 12:13
@omercier omercier merged commit accf292 into develop Jan 13, 2025
27 checks passed
@omercier omercier deleted the CTOR-1086-meraki-fix-vpn-tunnels branch January 13, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants