This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
sendrecv.py: poll bus with asyncio #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Jul 21, 2018
| @@ -113,7 +133,11 @@ def start_pipeline(self): | |||
| self.webrtc.connect('pad-added', self.on_incoming_stream) | |||
| self.pipe.set_state(Gst.State.PLAYING) | |||
|
|
|||
| async def handle_sdp(self, message): | |||
| self.bus = self.pipe.get_bus() | |||
| pollfd = self.bus.get_pollfd() | |||
There was a problem hiding this comment.
Second user of the new API I added in 1.14 :)
There was a problem hiding this comment.
yes, I was pretty happy to see this had just been added, however I had to fix an annotation issue right after 1.14.2 was merged, which reminds me this will break unless master is used :(
There was a problem hiding this comment.
I could put this in a try except block for now?
| def poll_cb(self): | ||
| done = False | ||
| while self.bus.peek() != None: | ||
| msg = self.bus.pop() |
There was a problem hiding this comment.
You can directly pop or not? Without peek first
There was a problem hiding this comment.
I assume that I could, as poll_cb will get called again immediately if all messages haven't been read, not sure what's best?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.