Bug fix: Offset Not Updated for Server-Side Subscriptions After Receiving Publications #107 #108
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks @shalom-aviv ! Will proceed with a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered an issue where, after manually reconnecting the client, the same chunk of history is repeatedly retrieved for a server-side subscription.
In debugging, we noticed that the offset sent during the connection request for a channel is the same as the offset returned in the server response, even when publications for that channel are delivered during the connection. This behavior indicates that while the messages are successfully delivered to the client, the offset for the channel is not updated accordingly.
More details is here issues/107
Spikeman's advice:
Before releasing the fix on the client, as a temporary workaround, the offset for publications in the target server channel can be stored and previously delivered messages can be skipped.